[Top] [All Lists]

Re: [PATCH v2 3/7] xfsdump: remove SIGCHLD handling

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH v2 3/7] xfsdump: remove SIGCHLD handling
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 10 Aug 2011 16:47:29 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1312497011-24840-4-git-send-email-wkendall@xxxxxxx>
References: <1312497011-24840-1-git-send-email-wkendall@xxxxxxx> <1312497011-24840-4-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Thu, 2011-08-04 at 17:30 -0500, Bill Kendall wrote:
> The multi-stream version of xfsdump for IRIX used sprocs for
> threading. When a "thread" exits with sprocs, a SIGCHLD is sent to
> the main thread just as if a regular child process exited. A future
> multi-stream version of xfsdump would use pthreads, so the SIGCHLD
> code is no longer needed. So:
> - No longer register for or handle SIGCHLD (SIGCLD).
> - Remove signal handling code for child processes.
> - Remove cldmgr_killall() as there are no children.

OK, it took a bit to verify this, but it looks to
me like most of the child thread stuff is inoperative,
because the "is miniroot" flag gets unconditionally
set, and with that set everything is single-threaded.

By not registering a handler for SIGCHLD you are
assuming the default, which is to ignore it.  It
might be better to explicitly set it to SIG_IGN.

Other than that, this looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>