xfs
[Top] [All Lists]

Re: [PATCH v3 1/2] xfstests: make more tests generic

To: <dave@xxxxxxxx>
Subject: Re: [PATCH v3 1/2] xfstests: make more tests generic
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 10 Aug 2011 11:36:09 -0500
Cc: <xfs@xxxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>, Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>, <linux-btrfs@xxxxxxxxxxxxxxx>
In-reply-to: <20110810155214.GE20461@xxxxxxxxxxxxx>
References: <cover.1312193821.git.sbehrens@xxxxxxxxxxxxxxxx> <c9703ec698de4de685eb6822773d3934452b8334.1312193821.git.sbehrens@xxxxxxxxxxxxxxxx> <20110810155214.GE20461@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-08-10 at 17:52 +0200, David Sterba wrote:
> Hi,
> 
> On Mon, Aug 01, 2011 at 12:31:19PM +0200, Stefan Behrens wrote:
> > Use _scratch_mkfs / _scratch_mkfs_sized instead of _scratch_mkfs_xfs
> > where possible.
> > Execute 015, 062, 083, 117, 120 and 192 for all filesystems, these
> > tests used to be XFS specific.
>  
> this patch is now in xfstests-dev and somehow breaks btrfs testing.

. . .

> there's a hardcoded path for mkfs.btrfs in common.rc:_scratch_mkfs_sized()
> 
> 335     btrfs)
> 336         /sbin/mkfs.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV -b $fssize
> 337         ;;
> 
> I have a /usr/local/ installation of btrfsprogs from git,
> _scratch_mkfs_sized() was not called for btrfs before.
> 
> Possible ways to fix this:
> 1) use /sbin/mkfs -t $FSTYP like _scratch_mkfs, or
> 2) set $MKFS_BTRFS_PROG like for some other filesystems
> 
> 
> What is preferred?

Whatever works.  My personal preference would be option (1)
if it works, since it's does the generic thing directly
rather than suggesting something special is needed for
btrfs.  But if that doesn't work, consistency rules so
MKFS_BTRFS_PROG "like for some other filesystems" is good.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>