[Top] [All Lists]

Re: [PATCH v3 1/2] xfstests: make more tests generic

To: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v3 1/2] xfstests: make more tests generic
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 10 Aug 2011 12:33:22 -0400
In-reply-to: <20110810155214.GE20461@xxxxxxxxxxxxx>
References: <cover.1312193821.git.sbehrens@xxxxxxxxxxxxxxxx> <c9703ec698de4de685eb6822773d3934452b8334.1312193821.git.sbehrens@xxxxxxxxxxxxxxxx> <20110810155214.GE20461@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Aug 10, 2011 at 05:52:14PM +0200, David Sterba wrote:
> there's a hardcoded path for mkfs.btrfs in common.rc:_scratch_mkfs_sized()
> 335     btrfs)
> 336         /sbin/mkfs.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV -b $fssize
> 337         ;;
> I have a /usr/local/ installation of btrfsprogs from git,
> _scratch_mkfs_sized() was not called for btrfs before.
> Possible ways to fix this:
> 1) use /sbin/mkfs -t $FSTYP like _scratch_mkfs, or
> 2) set $MKFS_BTRFS_PROG like for some other filesystems
> What is preferred?

Please send a patch for variant 2.  As soon as we have option using
the generic mkfs wrapper sounds like a good idea.  In addition to that
treating btrfs the same way as other filesystems is always good.

<Prev in Thread] Current Thread [Next in Thread>