| To: | Linux-MM <linux-mm@xxxxxxxxx> |
|---|---|
| Subject: | [PATCH 4/7] ext4: Warn if direct reclaim tries to writeback pages |
| From: | Mel Gorman <mgorman@xxxxxxx> |
| Date: | Wed, 10 Aug 2011 11:47:17 +0100 |
| Cc: | LKML <linux-kernel@xxxxxxxxxxxxxxx>, XFS <xfs@xxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Johannes Weiner <jweiner@xxxxxxxxxx>, Wu Fengguang <fengguang.wu@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Rik van Riel <riel@xxxxxxxxxx>, Minchan Kim <minchan.kim@xxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx> |
| In-reply-to: | <1312973240-32576-1-git-send-email-mgorman@xxxxxxx> |
| References: | <1312973240-32576-1-git-send-email-mgorman@xxxxxxx> |
Direct reclaim should never writeback pages. Warn if an attempt
is made.
Signed-off-by: Mel Gorman <mgorman@xxxxxxx>
---
fs/ext4/inode.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index e3126c0..95bb179 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2663,8 +2663,12 @@ static int ext4_writepage(struct page *page,
* We don't want to do block allocation, so redirty
* the page and return. We may reach here when we do
* a journal commit via journal_submit_inode_data_buffers.
- * We can also reach here via shrink_page_list
+ * We can also reach here via shrink_page_list but it
+ * should never be for direct reclaim so warn if that
+ * happens
*/
+ WARN_ON_ONCE((current->flags & (PF_MEMALLOC|PF_KSWAPD)) ==
+ PF_MEMALLOC);
goto redirty_page;
}
if (commit_write)
--
1.7.3.4
|
| Previous by Date: | [PATCH 2/7] mm: vmscan: Remove dead code related to lumpy reclaim waiting on pages under writeback, Mel Gorman |
|---|---|
| Next by Date: | [PATCH 5/7] mm: vmscan: Do not writeback filesystem pages in kswapd except in high priority, Mel Gorman |
| Previous by Thread: | Re: [PATCH 2/7] mm: vmscan: Remove dead code related to lumpy reclaim waiting on pages under writeback, Rik van Riel |
| Next by Thread: | Re: [PATCH 4/7] ext4: Warn if direct reclaim tries to writeback pages, Rik van Riel |
| Indexes: | [Date] [Thread] [Top] [All Lists] |