[Top] [All Lists]

Re: [PATCH] xfstests: fsx: fix fallocate logging

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fsx: fix fallocate logging
From: Josef Bacik <josef@xxxxxxxxxx>
Date: Tue, 09 Aug 2011 08:03:38 -0400
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20110809100658.GQ3162@dastard>
References: <1312818914-9950-1-git-send-email-josef@xxxxxxxxxx> <20110809100658.GQ3162@dastard>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110621 Fedora/3.1.11-1.fc15 Lightning/1.0b2 Thunderbird/3.1.11
On 08/09/2011 06:06 AM, Dave Chinner wrote:
> On Mon, Aug 08, 2011 at 11:55:14AM -0400, Josef Bacik wrote:
>> I've been getting segfaults on fsx tests with btrfs because we're using the
>> wrong values for the logging with fallocate.  We were using the numbers 1,2 
>> and
>> 3 to indicate the type of preallocate we were doing, however we use these to
>> point to an array, so obviously array[3] for a 3 element array is wrong, so 
>> fix
>> these to do 0,1, and 2.  Also spit out of we're using KEEP_SIZE in the log to
>> make it easier to figure out what's going on.  Thanks,
>> Signed-off-by: Josef Bacik <josef@xxxxxxxxxx>
> Already fixed.
> http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=77c06202484237e26774efbd1774c251b6bef0a9

Damnit, this is what I get for not git pulling first.  Thanks,


<Prev in Thread] Current Thread [Next in Thread>