xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fsx: fix the hole punching test

To: Josef Bacik <josef@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fsx: fix the hole punching test
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 9 Aug 2011 20:08:12 +1000
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <1312819080-10083-1-git-send-email-josef@xxxxxxxxxx>
References: <1312819080-10083-1-git-send-email-josef@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Aug 08, 2011 at 11:58:00AM -0400, Josef Bacik wrote:
> The test to make sure we support hole punching is just wrong.  First it passes
> the mode options into the len argument, and secondly it uses 0 for what I 
> assume
> was meant for the length, which doesn't work right.  Also it uses warn instead
> of just normal prt, which will cause xfstests to blow up for no reason.  So 
> fix
> the arguments and the error message so that we can actually run xfstests with
> fsx on fs's that don't support hole punching yet.  Thanks,
> 
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxx>

Already fixed:

http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=c18bf42de9d5d5fa05025754df1ff63f2147bd12

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>