| To: | Josef Bacik <josef@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: fsx: fix fallocate logging |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 9 Aug 2011 20:06:58 +1000 |
| Cc: | xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx |
| In-reply-to: | <1312818914-9950-1-git-send-email-josef@xxxxxxxxxx> |
| References: | <1312818914-9950-1-git-send-email-josef@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Aug 08, 2011 at 11:55:14AM -0400, Josef Bacik wrote: > I've been getting segfaults on fsx tests with btrfs because we're using the > wrong values for the logging with fallocate. We were using the numbers 1,2 > and > 3 to indicate the type of preallocate we were doing, however we use these to > point to an array, so obviously array[3] for a 3 element array is wrong, so > fix > these to do 0,1, and 2. Also spit out of we're using KEEP_SIZE in the log to > make it easier to figure out what's going on. Thanks, > > Signed-off-by: Josef Bacik <josef@xxxxxxxxxx> Already fixed. http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=77c06202484237e26774efbd1774c251b6bef0a9 Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: frequent kernel BUG and lockups - 2.6.39 + xfs_fsr, Marc Lehmann |
|---|---|
| Next by Date: | Re: [PATCH] xfstests: fsx: fix the hole punching test, Dave Chinner |
| Previous by Thread: | [PATCH] xfstests: fsx: fix fallocate logging, Josef Bacik |
| Next by Thread: | Re: [PATCH] xfstests: fsx: fix fallocate logging, Josef Bacik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |