[Top] [All Lists]

[PATCH 0/2] splice: i_mutex vs splice write deadlock V2

To: xfs@xxxxxxxxxxx
Subject: [PATCH 0/2] splice: i_mutex vs splice write deadlock V2
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 8 Aug 2011 16:45:25 +1000
Cc: linux-fsdevel@xxxxxxxxxxxxxxx
generic_file_splice_write() takes the inode->i_mutex after the
filesystem has taken whatever locks it needs to ensure sanity.
however, this typically violates the locking order of filesystems
with their own locks in that the order is usually i_mutex ->
filesystem lock.

XFS is such a case, and generic_file_splice_write() is generating
lockdep warnings because of lock inversions between the
inode->i_mutex and the XFS_I(inode)->i_iolock. There is also a
reported case of fio causing a deadlock when it mixes IO types
(e.g. splice vs direct IO).

Version 2:
- add a new function to take an actor to do the work of splicing the
  data to the file. Convert generic_file_splice_write to use this,
  and make XFS call it with a different actor fuction that avoids
  the i_mutex.

<Prev in Thread] Current Thread [Next in Thread>