xfs
[Top] [All Lists]

Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages

To: Johannes Weiner <jweiner@xxxxxxxxxx>
Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Aug 2011 10:18:07 -0400
Cc: Mel Gorman <mgorman@xxxxxxx>, Linux-MM <linux-mm@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, XFS <xfs@xxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Wu Fengguang <fengguang.wu@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Rik van Riel <riel@xxxxxxxxxx>, Minchan Kim <minchan.kim@xxxxxxxxx>, josef@xxxxxxxxxx
In-reply-to: <20110803140019.GA31026@xxxxxxxxxx>
References: <1311265730-5324-1-git-send-email-mgorman@xxxxxxx> <1311265730-5324-4-git-send-email-mgorman@xxxxxxx> <20110803105819.GA27199@xxxxxxxxxx> <20110803110629.GB27199@xxxxxxxxxx> <20110803134420.GH19099@xxxxxxx> <20110803140019.GA31026@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Aug 03, 2011 at 04:00:19PM +0200, Johannes Weiner wrote:
> > That said, in my current revision of the series, I've dropped these
> > patches altogether as page migration should be able to trigger the same
> > warnings but be called from paths that are of less concern for stack
> > overflows (or at the very least be looked at as a separate series).
> 
> Doesn't this only apply to btrfs which has no own .migratepage aop for
> file pages?  The others use buffer_migrate_page.
> 
> But if you dropped them anyway, it does not matter :)

Note that the mid-term plan is to kill ->writepage as an address space
method.  Besides the usage from reclaim as as callbacks to
write_cache_pages and write_one_page (which can be made explicit
arguments) the only remaining user is the above mentioned fallback.

Josef, any chance you could switch btrfs over to implement a proper
->migratepage?

<Prev in Thread] Current Thread [Next in Thread>