[Top] [All Lists]

Re: [PATCH 0/4] xfsdump: convert to using the POSIX signal API

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/4] xfsdump: convert to using the POSIX signal API
From: Bill Kendall <wkendall@xxxxxxx>
Date: Wed, 03 Aug 2011 07:07:52 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110803120245.GA25335@xxxxxxxxxxxxx>
References: <1311972011-1446-1-git-send-email-wkendall@xxxxxxx> <20110803105911.GA7226@xxxxxxxxxxxxx> <4E3937B1.7050207@xxxxxxx> <20110803120245.GA25335@xxxxxxxxxxxxx>
User-agent: Thunderbird (X11/20080502)
Christoph Hellwig wrote:
On Wed, Aug 03, 2011 at 06:57:37AM -0500, Bill Kendall wrote:
Christoph Hellwig wrote:

one thing I noticed looking over the code to understand your changes
is that there still is a lot of dead code in xfsdump.  One that
has a lot of implications and seems fairly useless for any non-IRIX
version is the miniroot mode.  Any chance we can rip that out?  There's
Yes, that's being used to disable multi-stream code in the Linux version.
The end of my multi-stream patch series removes the miniroot code.

Ooops, I didn't notice miniroot is actually defined to true.  Now that
I look deeper that also answers my comment about the duplicate signal
setup in main - one it's done for the miniroot case, and once for the
!miniroot case.

Now that we uses EPIPE instead of SIGPIPE is there actually any good
reason to do this setup in two different places?

Nope, I'll resubmit with this change.


<Prev in Thread] Current Thread [Next in Thread>