xfs
[Top] [All Lists]

Re: [PATCH 0/4] xfsdump: convert to using the POSIX signal API

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/4] xfsdump: convert to using the POSIX signal API
From: Bill Kendall <wkendall@xxxxxxx>
Date: Wed, 03 Aug 2011 06:57:37 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110803105911.GA7226@xxxxxxxxxxxxx>
References: <1311972011-1446-1-git-send-email-wkendall@xxxxxxx> <20110803105911.GA7226@xxxxxxxxxxxxx>
User-agent: Thunderbird 1.5.0.14ubu (X11/20080502)
Christoph Hellwig wrote:
Bill,

one thing I noticed looking over the code to understand your changes
is that there still is a lot of dead code in xfsdump.  One that
has a lot of implications and seems fairly useless for any non-IRIX
version is the miniroot mode.  Any chance we can rip that out?  There's

Yes, that's being used to disable multi-stream code in the Linux version.
The end of my multi-stream patch series removes the miniroot code.

also a lot of code under #ifdef HIDDEN - it would be good to go through
these and see we can just be removed, and if anything is still useful
moved under more self-explaining ifdefs.

Will add it to my list.

Bill

<Prev in Thread] Current Thread [Next in Thread>