xfs
[Top] [All Lists]

Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages

To: Mel Gorman <mgorman@xxxxxxx>
Subject: Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages
From: Johannes Weiner <jweiner@xxxxxxxxxx>
Date: Wed, 3 Aug 2011 13:06:29 +0200
Cc: Linux-MM <linux-mm@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, XFS <xfs@xxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Wu Fengguang <fengguang.wu@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Rik van Riel <riel@xxxxxxxxxx>, Minchan Kim <minchan.kim@xxxxxxxxx>
In-reply-to: <20110803105819.GA27199@xxxxxxxxxx>
References: <1311265730-5324-1-git-send-email-mgorman@xxxxxxx> <1311265730-5324-4-git-send-email-mgorman@xxxxxxx> <20110803105819.GA27199@xxxxxxxxxx>
On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote:
> On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote:
> > Direct reclaim should never writeback pages. Warn if an attempt
> > is made.
> > 
> > Signed-off-by: Mel Gorman <mgorman@xxxxxxx>
> 
> Acked-by: Johannes Weiner <jweiner@xxxxxxxxxx>

Oops, too fast.

Shouldn't the WARN_ON() be at the top of the function, rather than
just warn when the write is deferred due to delalloc?

<Prev in Thread] Current Thread [Next in Thread>