xfs
[Top] [All Lists]

Re: [PATCH 3/4] xfsdump: remove SIGCHLD handling

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/4] xfsdump: remove SIGCHLD handling
From: Bill Kendall <wkendall@xxxxxxx>
Date: Tue, 02 Aug 2011 09:13:50 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110802102245.GA22979@xxxxxxxxxxxxx>
References: <1311972011-1446-1-git-send-email-wkendall@xxxxxxx> <1311972011-1446-4-git-send-email-wkendall@xxxxxxx> <20110802102245.GA22979@xxxxxxxxxxxxx>
User-agent: Thunderbird 1.5.0.14ubu (X11/20080502)
Christoph Hellwig wrote:
On Fri, Jul 29, 2011 at 03:40:10PM -0500, Bill Kendall wrote:
The multi-stream version of xfsdump for IRIX used sprocs for
threading. When a "thread" exits with sprocs, a SIGCHLD is sent to
the main thread just as if a regular child process exited. A future
multi-stream version of xfsdump would use pthreads, so the SIGCHLD
code is no longer needed. So:

- No longer register for or handle SIGCHLD (SIGCLD).
- Remove signal handling code for child processes.
- Remove cldmgr_killall() as there are no children.

Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

does this mean you're actively working on multi-threaded dump for Linux?

Indeed...I didn't want to come right out and say it, in case I get side
tracked. :) But hoping to have patches up for review in the next week or
two.

Bill

<Prev in Thread] Current Thread [Next in Thread>