xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfsdump: remove conditional OPENMASKED code

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfsdump: remove conditional OPENMASKED code
From: Bill Kendall <wkendall@xxxxxxx>
Date: Tue, 02 Aug 2011 09:07:22 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110802101325.GA16239@xxxxxxxxxxxxx>
References: <1311972011-1446-1-git-send-email-wkendall@xxxxxxx> <1311972011-1446-2-git-send-email-wkendall@xxxxxxx> <20110802101325.GA16239@xxxxxxxxxxxxx>
User-agent: Thunderbird 1.5.0.14ubu (X11/20080502)
Christoph Hellwig wrote:
On Fri, Jul 29, 2011 at 03:40:08PM -0500, Bill Kendall wrote:
xfsdump contains a couple wrapper functions which block signals
during an open(2) call. This code is conditionally compiled and has
not been enabled for a long time. Remove the wrappers rather than
converting them to use the POSIX signal API.

Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Any idea what this code was used for?  Driver-specific open quirks on
IRIX?

Not sure, but probably something along those lines. The original
revision in the IRIX tree has the OPENMASKED code, but it too
is not enabled.

Thanks for the review.

Bill

<Prev in Thread] Current Thread [Next in Thread>