xfs
[Top] [All Lists]

Re: [PATCH 3/4] xfsdump: remove SIGCHLD handling

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH 3/4] xfsdump: remove SIGCHLD handling
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 2 Aug 2011 06:22:45 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1311972011-1446-4-git-send-email-wkendall@xxxxxxx>
References: <1311972011-1446-1-git-send-email-wkendall@xxxxxxx> <1311972011-1446-4-git-send-email-wkendall@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jul 29, 2011 at 03:40:10PM -0500, Bill Kendall wrote:
> The multi-stream version of xfsdump for IRIX used sprocs for
> threading. When a "thread" exits with sprocs, a SIGCHLD is sent to
> the main thread just as if a regular child process exited. A future
> multi-stream version of xfsdump would use pthreads, so the SIGCHLD
> code is no longer needed. So:
> 
> - No longer register for or handle SIGCHLD (SIGCLD).
> - Remove signal handling code for child processes.
> - Remove cldmgr_killall() as there are no children.
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

does this mean you're actively working on multi-threaded dump for Linux?

<Prev in Thread] Current Thread [Next in Thread>