xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfsdump: process EPIPE instead of catching SIGPIPE

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH 2/4] xfsdump: process EPIPE instead of catching SIGPIPE
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 2 Aug 2011 06:15:30 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1311972011-1446-3-git-send-email-wkendall@xxxxxxx>
References: <1311972011-1446-1-git-send-email-wkendall@xxxxxxx> <1311972011-1446-3-git-send-email-wkendall@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jul 29, 2011 at 03:40:09PM -0500, Bill Kendall wrote:
> Looking forward towards a multi-threaded xfsdump, it's simpler to
> handle pipe failures as a system call failure (EPIPE) rather than
> through a signal handler which may run in a separate thread. The
> existing error handling code handles EPIPE just fine, so the only
> required change is to ignore SIGPIPE. Some sections of code already
> temporarily ignore SIGPIPE -- they no longer need to do so since it
> will already be ignored.

Looks good, and the less we do with signals, the better.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 2/4] xfsdump: process EPIPE instead of catching SIGPIPE, Christoph Hellwig <=