xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: allow multi-digit dialog prompts

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH] xfsdump: allow multi-digit dialog prompts
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 2 Aug 2011 05:55:37 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1311784913-14191-1-git-send-email-wkendall@xxxxxxx>
References: <1311784913-14191-1-git-send-email-wkendall@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 27, 2011 at 11:41:53AM -0500, Bill Kendall wrote:
> xfsdump issues a multiple-choice dialog in various circumstances
> (e.g., media change request). An assert incorrectly limits this to
> at most 8 choices even though the code can handle up to 9.  Remove
> the assert and change the code to handle multi-digit responses.
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>