xfs
[Top] [All Lists]

[61/70] xfs [stable only]: restart busy extent search after node removal

To: linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxx, xfs-oss <xfs@xxxxxxxxxxx>
Subject: [61/70] xfs [stable only]: restart busy extent search after node removal
From: Greg KH <gregkh@xxxxxxx>
Date: Mon, 01 Aug 2011 16:19:16 -0700
Cc: stable-review@xxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, alan@xxxxxxxxxxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxx>
In-reply-to: <20110801232124.GA15313@xxxxxxxxx>
User-agent: quilt/0.48-16.4
2.6.39-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Eric Sandeen <sandeen@xxxxxxxxxxx>

A user on #xfs reported that a log replay was oopsing in
__rb_rotate_left() with a null pointer deref, and provided
an xfs_metadump image for reproduction and testing.

I traced this down to the fact that in xfs_alloc_busy_insert(),
we erased a node with rb_erase() when the new node overlapped,
but left the erased node specified as the parent node for the
new insertion.

So when we try to insert a new node with an erased node as
its parent, obviously things go very wrong.

Upstream,
97d3ac75e5e0ebf7ca38ae74cebd201c09b97ab2 xfs: exact busy extent tracking
actually fixed this, but as part of a much larger change.  Here's
the relevant code from that commit:

                * We also need to restart the busy extent search from the
                * tree root, because erasing the node can rearrange the
                * tree topology.
                */
               rb_erase(&busyp->rb_node, &pag->pagb_tree);
               busyp->length = 0;
               return false;

We can do essentially the same thing to older codebases by restarting
the tree search after the erase.

This should apply to .35.y through .39.y, and was tested on .39
with the oopsing replay reproducer.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Reviewed-by: Alex Elder <aelder@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
---

---
 fs/xfs/xfs_alloc.c |    6 ++++++
 1 file changed, 6 insertions(+)

--- a/fs/xfs/xfs_alloc.c
+++ b/fs/xfs/xfs_alloc.c
@@ -2610,6 +2610,12 @@ restart:
                                        new->bno + new->length) -
                                min(busyp->bno, new->bno);
                new->bno = min(busyp->bno, new->bno);
+               /*
+                * Start the search over from the tree root, because
+                * erasing the node can rearrange the tree topology.
+                */
+               spin_unlock(&pag->pagb_lock);
+               goto restart;
        } else
                busyp = NULL;
 


<Prev in Thread] Current Thread [Next in Thread>
  • [61/70] xfs [stable only]: restart busy extent search after node removal, Greg KH <=