xfs
[Top] [All Lists]

Re: [PATCH] jfs: flush journal completely before releasing metadata ino

To: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx>
Subject: Re: [PATCH] jfs: flush journal completely before releasing metadata inodes
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 1 Aug 2011 14:32:55 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <4E36F086.4070900@xxxxxxxxxx>
References: <20110729155039.GA28306@xxxxxxxxxxxxx> <4E32D9EB.9020406@xxxxxxxxxx> <4E36F086.4070900@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Aug 01, 2011 at 01:29:26PM -0500, Dave Kleikamp wrote:
> On 07/29/2011 11:03 AM, Dave Kleikamp wrote:
> > On 07/29/2011 10:50 AM, Christoph Hellwig wrote:
> >> The patch below adds basic jfs support to xfstests.  Unfortunately it
> >> doesn't get very far, as test 001 already blows up with a kernel crash,
> >> as do 011 and 013 as other random picks.
> > 
> > Great :-)
> > 
> > Seems to be a good idea to support jfs. I'll carve out some time to
> > reproduce and debug the crashes.
> 
> This fixes a race during unmount. We need to not only make sure that
> the journal is completely written, but that the metadata changes make
> it to disk before releasing ipimap and ipbmap.

Looks sensible.  How far does a ./check -g auto get now?  Any other
failures?

<Prev in Thread] Current Thread [Next in Thread>