xfs
[Top] [All Lists]

Re: [PATCH v2 1/4] xfstests: Changed test 062 to be generic for all file

To: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 1/4] xfstests: Changed test 062 to be generic for all filesystems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 30 Jul 2011 10:25:30 -0400
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <95dfa968c48d2bd1095876a6db3369672e76db5f.1311953979.git.sbehrens@xxxxxxxxxxxxxxxx>
References: <cover.1311953979.git.sbehrens@xxxxxxxxxxxxxxxx> <95dfa968c48d2bd1095876a6db3369672e76db5f.1311953979.git.sbehrens@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jul 29, 2011 at 06:06:58PM +0200, Stefan Behrens wrote:
> Changed the test 062 to be generic for all filesystems and to be
> executed for all filesystems.
> Remove output of mkfs since this is specific to mkfs.xfs and now
> filtered out.

The first three patches look good, but can you please merge them into
on.  And maybe make the subject description a bit less verbose, e.g.

xfstests: make more tests generic

Use _scratch_mkfs / _scratch_mkfs_sized instead of _scratch_mkfs_xfs
where possible. 

<Prev in Thread] Current Thread [Next in Thread>