xfs
[Top] [All Lists]

Re: 2.6.xx: NFS: directory motion/cam2 contains a readdir loop

To: Justin Piszcz <jpiszcz@xxxxxxxxxxxxxxx>
Subject: Re: 2.6.xx: NFS: directory motion/cam2 contains a readdir loop
From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
Date: Fri, 29 Jul 2011 18:03:36 -0400
Cc: Bryan Schumaker <bjschuma@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <alpine.DEB.2.02.1107291656340.25432@xxxxxxxxxxxxxxxx>
Organization: NetApp Inc
References: <alpine.DEB.2.02.1107270952270.1451@xxxxxxxxxxxxxxxx> <20110727160752.GC974@xxxxxxxxxxxx> <alpine.DEB.2.02.1107271227340.1451@xxxxxxxxxxxxxxxx> <20110727181111.GA23009@xxxxxxxxxxxxx> <alpine.DEB.2.02.1107271530340.1451@xxxxxxxxxxxxxxxx> <20110727193937.GA5354@xxxxxxxxxxxxx> <alpine.DEB.2.02.1107271540100.1451@xxxxxxxxxxxxxxxx> <20110727194722.GA9345@xxxxxxxxxxxxx> <1311799021.25645.41.camel@xxxxxxxxxxxxxxxxxx> <1311800051.25645.43.camel@xxxxxxxxxxxxxxxxxx> <1311800195.25645.45.camel@xxxxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1107271723500.25432@xxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1107271844100.25432@xxxxxxxxxxxxxxxx> <1311886137.27285.2.camel@xxxxxxxxxxxxxxxxxx> <4E331D86.7060801@xxxxxxxxxx> <alpine.DEB.2.02.1107291656340.25432@xxxxxxxxxxxxxxxx>
On Fri, 2011-07-29 at 16:59 -0400, Justin Piszcz wrote: 
> On Fri, 29 Jul 2011, Bryan Schumaker wrote:
> 
> > How does this look for printing out more information when a cookie loop is 
> > detected?  Is there anything else that should be printed out?  My patch 
> > applies on top of Trond's from yesterday.
> 
> 
> Hi,
> 
> This fails against 2.6.38:
> 
> patching file fs/nfs/dir.c
> Hunk #1 FAILED at 134.
> Hunk #2 FAILED at 173.
> Hunk #3 FAILED at 323.
> Hunk #4 FAILED at 336.
> Hunk #5 FAILED at 349.
> Hunk #6 succeeded at 320 (offset -48 lines).
> Hunk #7 FAILED at 741.
> Hunk #8 succeeded at 716 (offset -59 lines).
> Hunk #9 succeeded at 749 (offset -59 lines).
> Hunk #10 succeeded at 763 (offset -59 lines).
> 6 out of 10 hunks FAILED -- saving rejects to file fs/nfs/dir.c.rej
> patching file include/linux/nfs_fs.h
> Hunk #1 FAILED at 99.
> 1 out of 1 hunk FAILED -- saving rejects to file include/linux/nfs_fs.h.rej
> atom:/usr/src/linux#
> 
> And the 3.0 kernel is broken for my wireless adapter:
> http://www.gossamer-threads.com/lists/linux/kernel/1411576
> 
> If you can make a combined patch for 2.6.38 I can try it, 2.6.39+ have a
> horrible driver (rt2800usb) and 1 person emailed me as well stating the
> same thing off-list (they stick with the manufacturer's driver or the *sta
> one).

I don't understand. The readdir loop detection code was first merged
upstream in 2.6.39. 2.6.38 doesn't report any loops...

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com

<Prev in Thread] Current Thread [Next in Thread>