| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/4] xfstests: Add support for btrfs in 079 |
| From: | Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx> |
| Date: | Fri, 29 Jul 2011 16:30:12 +0200 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha1; c=relaxed/relaxed; t=1311949821; l=1358; s=domk; d=giantdisaster.de; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Subject:CC:To:MIME-Version:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=tlscrtyFM9rFd02k6uSzVfIhfNM=; b=OwY7qrUhkjWLaieNaMGIfe891E0vrjMqOWAyDdNnCq94uVimoEKKBmN1PRJpyLrTCjY go3WblUk/7Q2i5aKATwPnYie3rO/NTYkwPhtASg/Z9W37dZ1GpomhtBRGFy9IeXMCOCqN 8b2pg9SIZoismeoxgh0mh45yB355D9EZ6LQ= |
| In-reply-to: | <20110729123028.GA4764@xxxxxxxxxxxxx> |
| References: | <cover.1311776403.git.sbehrens@xxxxxxxxxxxxxxxx> <0cbb002def872039fd8c0bb90ceb5f6bf0e15b02.1311776403.git.sbehrens@xxxxxxxxxxxxxxxx> <20110728085158.GD3407@xxxxxxxxxxxxx> <4E32A67E.9070306@xxxxxxxxxxxxxxxx> <20110729123028.GA4764@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0) Gecko/20110624 Thunderbird/5.0 |
On 7/29/2011 2:30 PM, Christoph Hellwig wrote: > On Fri, Jul 29, 2011 at 02:24:30PM +0200, Stefan Behrens wrote: >> The difference between the filesystems is whether the append-only >> flag from the directory is inherited to the newly create file inside >> that directory. XFS does not inherit that append-only flag, ext2, >> ext3, ext4 and btrfs do inherit it. > Having different behaviour for different filesystems is a bad thing, > and given that XFS is the lonely one out there I think we should > remove the inheritance. I'll preparate a patch for it. In order to make it consistent, it would be needed to _add_ the inheritance to XFS, not to remove it from XFS. Or to remove it from ext2, ext3, ext4 and btrfs. A different thread is whether it makes sense to inherit this flag from directories to files. I would prefer to not inherit the append-only flag from a directory to files created in that directory, because the use case for setting the append-only flag on directories is different to the use case for having the flag set on files. I cannot imagine use cases where the inheritance of this flag from the directory to the file is useful. But I cannot find real-world use cases for setting this flag on directories anyway, to all imaginable needs in this area the solution is the sticky bit on the directory or ACLs. |
| Previous by Date: | Re: [RFC PATCH 0/8] Reduce filesystem writeback from page reclaim v2, Andrew Lutomirski |
|---|---|
| Next by Date: | [PATCH, RFC] jfs support for xfstests, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 4/4] xfstests: Add support for btrfs in 079, Christoph Hellwig |
| Next by Thread: | [PATCH 2/4] xfstests: Add support for btrfs in 083, 117, 120 and 192, Stefan Behrens |
| Indexes: | [Date] [Thread] [Top] [All Lists] |