xfs
[Top] [All Lists]

Re: "xfs: fix error handling for synchronous writes" revisited

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: "xfs: fix error handling for synchronous writes" revisited
From: Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>
Date: Fri, 29 Jul 2011 13:12:59 +0530
Cc: xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=FKeHd4G2dkBNRJqGEijyrrjIBWkGtWzqXoQ4kBP54c8=; b=HFn6pU0rVsd2u5W+YfxggLvN5p8hsDCe8RXbM+TQSC/KbeTYty3WmoIPbTBt6JVE9L hhTfEYwyh0woUlykoh1qwRlYpJrs1nTRHIIhYiFq9C0d1cHeEuiEn7qRx6r6UcjHqFBx mSmenJCwD0p7sZyBIPI3foCpFj9jI88wi+spU=
In-reply-to: <20110728145020.GA30785@xxxxxxxxxxxxx>
References: <CAB4K4y6-2odbRhqn6q7ZDOxqF9oUcj2zKvyCEV6374QGyM-ddA@xxxxxxxxxxxxxx> <20110728145020.GA30785@xxxxxxxxxxxxx>
xfs: fix for hang during synchronous buffer write error

If removed storage while synchronous buffer write underway,
"xfslogd" hangs.

Detailed log http://oss.sgi.com/archives/xfs/2011-07/msg00740.html

Related work bfc60177f8ab509bc225becbb58f7e53a0e33e81
"xfs: fix error handling for synchronous writes"

Given that xfs_bwrite actually does the shutdown already after
waiting for the b_iodone completion and given that we actually
found that calling xfs_force_shutdown from inside
xfs_buf_iodone_callbacks was a major contributor the problem
it better to drop this call.

Signed-off-by: Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx>

diff -Nurp -X linux/Documentation/dontdiff linux/fs/xfs/xfs_buf_item.c
linux-Dirty/fs/xfs/xfs_buf_item.c
--- linux/fs/xfs/xfs_buf_item.c 2011-06-09 10:05:18.000000000 +0530
+++ linux-Dirty/fs/xfs/xfs_buf_item.c   2011-07-28 15:53:51.000000000 +0530
@@ -1028,7 +1028,6 @@ xfs_buf_iodone_callbacks(
        XFS_BUF_UNDELAYWRITE(bp);

        trace_xfs_buf_error_relse(bp, _RET_IP_);
-       xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR);

 do_callbacks:
        xfs_buf_do_callbacks(bp, lip);

<Prev in Thread] Current Thread [Next in Thread>