xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfs: flag all buffers as metadata

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 1/3] xfs: flag all buffers as metadata
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 26 Jul 2011 18:40:16 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1311719935.11557.12.camel@doink>
References: <20110726150633.GA17400@xxxxxxxxxxxxx> <20110726150644.GA18000@xxxxxxxxxxxxx> <1311719935.11557.12.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jul 26, 2011 at 05:38:55PM -0500, Alex Elder wrote:
> On Tue, 2011-07-26 at 11:06 -0400, Christoph Hellwig wrote: 
> > Now that REQ_META bios aren't treated specially in the CFQ I/O schedule
> > anymore, we can tag all buffers as metadata to make blktrace traces more
> > meaningful.  Note that we use buffers also to zero out partial blocks
> > in the preallocation / hole punching code, and while they operate on
> > data blocks the zeros written certainly aren't data.  I think this case
> > is borderline metadata enough to not bother special casing it.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> This looks good.  I plan to re-base the xfs master branch
> after 3.1-rc1 is out, so I'll wait until after that to
> commit this (and the others in this series).

I'd prefer to get it out to Linus ASAP after some review.  Just
committing it to for-linus for now and later rebasing master on top
should do fine for that.

<Prev in Thread] Current Thread [Next in Thread>