xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfs: optimize the negative xattr caching

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfs: optimize the negative xattr caching
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 26 Jul 2011 17:39:11 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110726150729.GC18000@xxxxxxxxxxxxx>
References: <20110726150633.GA17400@xxxxxxxxxxxxx> <20110726150729.GC18000@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-07-26 at 11:07 -0400, Christoph Hellwig wrote:
> Since the addition of file capabilities every write needs to read xattrs to
> check if we have any capabilities to clear.  In Linux 3.0 Andi Kleen added
> a flag to cache the fact that we do not have any attributes on an inode.
> Make sure to already mark a file as not having any attributes when reading
> it from disk in case it doesn't even have an attribute fork.  Based on an
> earlier patch from Andi Kleen.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good to me.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>