xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfs: prevent against ioend livelocks in xfs_file_fsync

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] xfs: prevent against ioend livelocks in xfs_file_fsync
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 26 Jul 2011 17:39:02 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110726150711.GB18000@xxxxxxxxxxxxx>
References: <20110726150633.GA17400@xxxxxxxxxxxxx> <20110726150711.GB18000@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-07-26 at 11:07 -0400, Christoph Hellwig wrote:
> We need to take some locks to prevent new ioends from coming in when we wait
> for all existing ones to go away.  Up to Linux 3.0 that was done using the
> i_mutex held by the VFS fsync code, but now that we are called without
> it we need to take care of it ourselves.  Use the I/O lock instead of
> i_mutex just like we do in other places.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>