| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/3] xfs: flag all buffers as metadata |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Tue, 26 Jul 2011 17:38:55 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20110726150644.GA18000@xxxxxxxxxxxxx> |
| References: | <20110726150633.GA17400@xxxxxxxxxxxxx> <20110726150644.GA18000@xxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Tue, 2011-07-26 at 11:06 -0400, Christoph Hellwig wrote: > Now that REQ_META bios aren't treated specially in the CFQ I/O schedule > anymore, we can tag all buffers as metadata to make blktrace traces more > meaningful. Note that we use buffers also to zero out partial blocks > in the preallocation / hole punching code, and while they operate on > data blocks the zeros written certainly aren't data. I think this case > is borderline metadata enough to not bother special casing it. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> This looks good. I plan to re-base the xfs master branch after 3.1-rc1 is out, so I'll wait until after that to commit this (and the others in this series). If you want me to do something different, let me know. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: PM / hibernate xfs lock up / xfs_reclaim_inodes_ag, Rafael J. Wysocki |
|---|---|
| Next by Date: | Re: [PATCH 2/3] xfs: prevent against ioend livelocks in xfs_file_fsync, Alex Elder |
| Previous by Thread: | [PATCH 1/3] xfs: flag all buffers as metadata, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 1/3] xfs: flag all buffers as metadata, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |