[Top] [All Lists]

Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio_write

To: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio_write
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 26 Jul 2011 10:21:48 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>, <viro@xxxxxxxxxxxxxxxxxx>, <jack@xxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <20110724120330.GC1626@xxxxxxxxxxxxxx>
References: <1309370716-12235-1-git-send-email-josef@xxxxxxxxxx> <20110723180942.GA1616@xxxxxxxxxxxxxx> <4E2B2E88.8080006@xxxxxxxxxx> <20110723203824.GB1652@xxxxxxxxxxxxxx> <20110723220212.GA1648@xxxxxxxxxxxxxx> <20110724111625.GA12658@xxxxxxxxxxxxx> <20110724115420.GA1626@xxxxxxxxxxxxxx> <20110724115826.GB1626@xxxxxxxxxxxxxx> <20110724120330.GC1626@xxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Sun, 2011-07-24 at 14:03 +0200, Markus Trippelsdorf wrote:
> The fsync prototype change commit 02c24a82187d accidentally overwrote
> the ssize_t return value of xfs_file_aio_write with 0 for SYNC type
> writes. Fix this by checking if an error occured when calling
> xfs_file_fsync and only change the return value in this case.
> In addition xfs_file_fsync actually returns a normal negative error, so
> fix this, too.
> Signed-off-by: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Tested-by: Christoph Hellwig <hch@xxxxxx>

Finally looking at this I noticed the same thing Christoph
did; thanks for fixing both.  Your change got committed
yesterday via Al Viro's VFS tree.


<Prev in Thread] Current Thread [Next in Thread>