xfs
[Top] [All Lists]

Re: [PATCH XFSPROGS 2/3] Build without enabling DEBUG by default

To: "Ted Ts'o" <tytso@xxxxxxx>
Subject: Re: [PATCH XFSPROGS 2/3] Build without enabling DEBUG by default
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 26 Jul 2011 11:10:33 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110723013214.GA22837@xxxxxxxxxxxxx>
References: <1311292237-4155-1-git-send-email-tytso@xxxxxxx> <1311292237-4155-2-git-send-email-tytso@xxxxxxx> <20110722141753.GA19681@xxxxxxxxxxxxx> <20110722183048.GC25092@xxxxxxxxx> <20110722183830.GA21744@xxxxxxxxxxxxx> <20110722223458.GD25092@xxxxxxxxx> <20110723013214.GA22837@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jul 22, 2011 at 09:32:14PM -0400, Christoph Hellwig wrote:
> > diff --git a/include/builddefs.in b/include/builddefs.in
> > index 4c8ec64..81ebfcd 100644
> > --- a/include/builddefs.in
> > +++ b/include/builddefs.in
> > @@ -25,6 +25,7 @@ OPTIMIZER = @opt_build@
> >  MALLOCLIB = @malloc_lib@
> >  LOADERFLAGS = @LDFLAGS@
> >  LTLDFLAGS = @LDFLAGS@
> > +CFLAGS = @CFLAGS@
> >  
> >  LIBRT = @librt@
> >  LIBUUID = @libuuid@
> > 
> > Then I don't have to set an environment variable when running make; I
> > just have to pass it to configure.
> 
> This looks much better, and is indeed similar to some other fixes we
> recently had to put in, probably due to changing make behaviour.
> 
> If you add a signoff and a proper description I'll put it into all the
> repositories.

Can you at least provide the signoff?  I can take care of the rest if
this means I can get it in ASAP.

<Prev in Thread] Current Thread [Next in Thread>