xfs
[Top] [All Lists]

Re: [PATCH 00/12 v3] Remove number of macros from xfs_buf.h

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH 00/12 v3] Remove number of macros from xfs_buf.h
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 25 Jul 2011 12:36:58 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110722233933.14612.65879.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20110722233933.14612.65879.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-07-22 at 16:39 -0700, Chandra Seetharaman wrote:
> Hello All,
> 
> Here are few patchset to remove some of the macro definitions from 
> fs/xfs/linux-2.6/xfs_buf.h.
> 
> Please review and comment.
> 
> This set is version 3:
> Incorporated changes suggested by Alex Elder in patches 3/12, 8/12,
> 9/12 and 12/12
> 
> Version 2:
> Incorporated changes suggested by hristoph Hellwig in patches 2/12, 3/12,
> 7/12 and 10/12.

I forgot to mention before that I got some
feedback that removing these macros affects
portability to other platforms (BSD specifically).

I don't really seek to do that, and would like to
keep it so that XFS *can* port to other platforms.
Here we just face a trade-off between preserving
support for other environments (especially those
not under active development) and keeping the
leading edge of development clean, free to evolve,
and unencumbered by external requirements.

I acknowledge that by accepting these I'm leaning
toward progress of XFS despite its effect on
portability non-Linux environments (or even older
Linux kernels).

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>