xfs
[Top] [All Lists]

Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 25 Jul 2011 13:09:32 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Chandra Seetharaman <sekharan@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1311613642.2914.40.camel@doink>
References: <20110722233933.14612.65879.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110722233945.14612.1955.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110724113959.GD26332@xxxxxxxxxxxxx> <1311609452.2914.23.camel@doink> <20110725162718.GC2434@xxxxxxxxxxxxx> <1311613642.2914.40.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 25, 2011 at 12:07:22PM -0500, Alex Elder wrote:
> - Look into having xfs_qm_dqalloc() return ENOMEM when
>   it is unable to allocate a buffer, and fix all the
>   callers up the chain so they handle such a situation
>   appropriately.  Right now such errors get reset.

It's not.  We allocate buffers inside dirty transactions, so we
really cannot handle errors there.  I've been trying to fix that
last time in about 2002 or 2003, and it didn't go very far.

<Prev in Thread] Current Thread [Next in Thread>