xfs
[Top] [All Lists]

Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 25 Jul 2011 10:57:32 -0500
Cc: Chandra Seetharaman <sekharan@xxxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <20110724113959.GD26332@xxxxxxxxxxxxx>
References: <20110722233933.14612.65879.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110722233945.14612.1955.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110724113959.GD26332@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Sun, 2011-07-24 at 07:39 -0400, Christoph Hellwig wrote:
> > @@ -1247,6 +1247,7 @@ xlog_bdstrat(
> >  {
> >     struct xlog_in_core     *iclog = bp->b_fspriv;
> >  
> > +   bp->b_flags &= ~(XBF_FUA|XBF_FLUSH);
> 
> I don't think this is correct, we set these before calling into
> xlog_bdstrat, so this means we'll always stip it off after that.
> 
> Given that this area is more complicated than the pure macro removal
> how about letting it as-is for now?  I have some bigger refactoring
> in this area in my queue, and I'll just incorporate the
> XFS_BUF_ZEROFLAGS into it.

Christoph, are you suggesting that this one hunk just
be excluded from the series?  Or the entire patch?

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>