[Top] [All Lists]

Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 25 Jul 2011 09:51:40 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110722233945.14612.1955.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20110722233933.14612.65879.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110722233945.14612.1955.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-07-22 at 16:39 -0700, Chandra Seetharaman wrote:
> Remove the definition and usage of the macro XFS_BUF_ZEROFLAGS.
> In the specific contexts, not all flags need to be cleared. Hence the
> simplification.
> Rationale for xfs_log.c:
> from hch: XBF_READ and XBF_DELWRI will never be set here, XBF_WRITE
> XBF_ASYNC, and XBF_SYNCIO are set just below.
> Hence clearing only XBF_FUA and XBF_FLUSH would suffice.
> Rationale for xfs_log_recover.c
> from hch: XBF_READ, XBF_WRITE, XBF_ASYNC and XBF_DELWRI already get dealt with
> in xfs_bwrite a few lines down.
> from hch: XBF_SYNCIO, XBF_FUA and XBF_FLUSH are used only in log buffers. No
> need to clear them here.

Sorry, I reviewed this last week and signed off on it
but I see it's stuck in my mail outbox for some reason.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>
> ---

<Prev in Thread] Current Thread [Next in Thread>