On Mon, 2011-07-25 at 16:06 +0200, Lukas Czerner wrote:
> On Fri, 15 Jul 2011, Alex Elder wrote:
> > On Tue, 2011-06-28 at 16:26 +0200, Lukas Czerner wrote:
> > > When getting an inode tree pointer from an array inode_tree_ptrs, we
> > > should check if agno, which is used as a pointer to the array, lives
> > > within the file system, because if it is not, we can end up touching
> > > uninitialized memory. This may happen if we have corrupted directory
> > > entry.
> > >
> > > This commit fixes it by passing xfs_mount to affected functions and
> > > checking if agno really is inside the file system.
> > >
> > > This solves Red Hat bug #694706
> > >
> > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> > OK, it looks like there are basically four changes
> > here--adding the mount point argument to four functions
> > and using it to verify (or assert the validity of) the
> > an AG number. The rest of the changes are simply the
> > rippling-back effect of adding the mount point.
> > The change looks good to me. If nobody else objects to
> > the change I will commit this for you.
> > Reviewed-by: Alex Elder <aelder@xxxxxxx>
> Thanks Alex!
> I still can not see it in the git though, so what is the status of this
> patch ?
Sorry about that, I missed this one when I committed some
things last week. I'll get it in this week, likely today.