xfs
[Top] [All Lists]

Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsyn

To: Josef Bacik <josef@xxxxxxxxxx>
Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers
From: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
Date: Sun, 24 Jul 2011 00:02:12 +0200
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple; d=mail.ud10.udmedia.de; h= date:from:to:cc:subject:message-id:references:mime-version: content-type:in-reply-to; q=dns/txt; s=beta; bh=2R8bO3C6of+NId0X Fnv0uxd7EFYobJSosk7vIkyx2fM=; b=pGo147ZNqeYzYbJ3py1HN7N/VFbE/6pm me9g5XyNzYg+B7rbz+RW61k3Ju+P8keq4S1Wir0gIbf79mp6b8P4I56hf66CzWaP SA8NI0Z+NdV6N43/yU11o2xkXK7MuCq7rMq5Yn/pcuWxrTiG4xcxWizGOuYAf6RF SHwAj5BDV3A=
In-reply-to: <20110723203824.GB1652@xxxxxxxxxxxxxx>
References: <1309370716-12235-1-git-send-email-josef@xxxxxxxxxx> <20110723180942.GA1616@xxxxxxxxxxxxxx> <4E2B2E88.8080006@xxxxxxxxxx> <20110723203824.GB1652@xxxxxxxxxxxxxx>
On 2011.07.23 at 22:38 +0200, Markus Trippelsdorf wrote:
> On 2011.07.23 at 16:26 -0400, Josef Bacik wrote:
> > On 07/23/2011 02:09 PM, Markus Trippelsdorf wrote:
> > > On 2011.06.29 at 14:05 -0400, Josef Bacik wrote:
> > >> Btrfs needs to be able to control how filemap_write_and_wait_range() is 
> > >> called
> > >> in fsync to make it less of a painful operation, so push down taking 
> > >> i_mutex and
> > >> the calling of filemap_write_and_wait() down into the ->fsync() 
> > >> handlers.  Some
> > >> file systems can drop taking the i_mutex altogether it seems, like ext3 
> > >> and
> > >> ocfs2.  For correctness sake I just pushed everything down in all cases 
> > >> to make
> > >> sure that we keep the current behavior the same for everybody, and then 
> > >> each
> > >> individual fs maintainer can make up their mind about what to do from 
> > >> there.
> > >
> > > At least the xfs part of this patch is broken.
> > > Running the latest git-kernel bogofilter doesn't work anymore on my xfs
> > > partition. When I run "bogoutil -d wordlist.db" to dump the contents of
> > > the database, it produces no output at all.
> > >
> > 
> > Already fixed and sent a patch out earlier this week.  Thanks,
> 
> No. This happens with your patch already applied. See my other reply.

The following patch fixes the problem for me:

diff --git a/fs/xfs/linux-2.6/xfs_file.c b/fs/xfs/linux-2.6/xfs_file.c
index cca00f4..2e23e3d 100644
--- a/fs/xfs/linux-2.6/xfs_file.c
+++ b/fs/xfs/linux-2.6/xfs_file.c
@@ -881,11 +881,14 @@ xfs_file_aio_write(
        /* Handle various SYNC-type writes */
        if ((file->f_flags & O_DSYNC) || IS_SYNC(inode)) {
                loff_t end = pos + ret - 1;
+               int error;
 
                xfs_rw_iunlock(ip, iolock);
-               ret = -xfs_file_fsync(file, pos, end,
+               error = -xfs_file_fsync(file, pos, end,
                                      (file->f_flags & __O_SYNC) ? 0 : 1);
                xfs_rw_ilock(ip, iolock);
+               if (error)
+                       ret = error;
        }
 
 out_unlock:

-- 
Markus

<Prev in Thread] Current Thread [Next in Thread>