xfs
[Top] [All Lists]

Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsyn

To: Josef Bacik <josef@xxxxxxxxxx>
Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers
From: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
Date: Sat, 23 Jul 2011 22:38:24 +0200
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple; d=mail.ud10.udmedia.de; h= date:from:to:cc:subject:message-id:references:mime-version: content-type:in-reply-to; q=dns/txt; s=beta; bh=+i4+jLBOmt693W40 TJfYRjUfiIFruwf14KcVf6yzfR4=; b=UuVwARD7k/esFpu1685dUSMVX17CLkQ/ RKoTQXu4oYWPSJ1p4m0RGH8a3XfGmKSuSRk8PW4LTpzrJ/gpNGnUdk+6EZ8e9koq nSeTdYT0Ve3552LBtQFeLwqDVoulnTZu/mOSvhDQ+HzO+EfyQTiJJFBhW2QzmS2w X+nES3OeUIc=
In-reply-to: <4E2B2E88.8080006@xxxxxxxxxx>
References: <1309370716-12235-1-git-send-email-josef@xxxxxxxxxx> <20110723180942.GA1616@xxxxxxxxxxxxxx> <4E2B2E88.8080006@xxxxxxxxxx>
On 2011.07.23 at 16:26 -0400, Josef Bacik wrote:
> On 07/23/2011 02:09 PM, Markus Trippelsdorf wrote:
> > On 2011.06.29 at 14:05 -0400, Josef Bacik wrote:
> >> Btrfs needs to be able to control how filemap_write_and_wait_range() is 
> >> called
> >> in fsync to make it less of a painful operation, so push down taking 
> >> i_mutex and
> >> the calling of filemap_write_and_wait() down into the ->fsync() handlers.  
> >> Some
> >> file systems can drop taking the i_mutex altogether it seems, like ext3 and
> >> ocfs2.  For correctness sake I just pushed everything down in all cases to 
> >> make
> >> sure that we keep the current behavior the same for everybody, and then 
> >> each
> >> individual fs maintainer can make up their mind about what to do from 
> >> there.
> >
> > At least the xfs part of this patch is broken.
> > Running the latest git-kernel bogofilter doesn't work anymore on my xfs
> > partition. When I run "bogoutil -d wordlist.db" to dump the contents of
> > the database, it produces no output at all.
> >
> 
> Already fixed and sent a patch out earlier this week.  Thanks,

No. This happens with your patch already applied. See my other reply.

-- 
Markus

<Prev in Thread] Current Thread [Next in Thread>