xfs
[Top] [All Lists]

Re: [PATCH XFSPROGS 2/3] Build without enabling DEBUG by default

To: "Ted Ts'o" <tytso@xxxxxxx>
Subject: Re: [PATCH XFSPROGS 2/3] Build without enabling DEBUG by default
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 22 Jul 2011 14:38:30 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110722183048.GC25092@xxxxxxxxx>
References: <1311292237-4155-1-git-send-email-tytso@xxxxxxx> <1311292237-4155-2-git-send-email-tytso@xxxxxxx> <20110722141753.GA19681@xxxxxxxxxxxxx> <20110722183048.GC25092@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jul 22, 2011 at 02:30:48PM -0400, Ted Ts'o wrote:
> I added some debugging statements in libxfs/Makefile, and found this
> (see below).

You can get most of this by simply using make V=1, not just in xfsprogs,
but in most projects using silent make output (including those using
automake)

> It looks like the problem is that GNU make 3.81 is doing an immediate
> expansion of this line in builddefs:

I'm having GNU make 3.81 on most of my test systems as well, so that
alone can't be the whole issue.

> CFLAGS += $(FCFLAGS) $(GCFLAGS) $(PCFLAGS) $(LCFLAGS)
> 

> LTCOMPILE is /bin/sh ../libtool --quiet --tag=CC --mode=compile gcc 
> -I/kbuild/xfstests/bld/include -g -O2 -DDEBUG -DVERSION="3.1.5" 
> -DLOCALEDIR="//share/locale" -DPACKAGE="xfsprogs" -I./include 
> -DENABLE_GETTEXT -D_GNU_SOURCE -D_XOPEN_SOURCE=500 -D_FILE_OFFSET_BITS=64 
> -funsigned-char -fno-strict-aliasing -Wall -g -O2 -DDEBUG -DVERSION="3.1.5" 
> -DLOCALEDIR="//share/locale" -DPACKAGE="xfsprogs" -I./include 
> -DENABLE_GETTEXT -D_GNU_SOURCE -D_XOPEN_SOURCE=500 -D_FILE_OFFSET_BITS=64 
> -funsigned-char -fno-strict-aliasing -Wall -I. -g -O2 -DNDEBUG 
> -DVERSION="3.1.5" -DLOCALEDIR="//share/locale" -DPACKAGE="xfsprogs" 
> -I../include -DENABLE_GETTEXT -D_GNU_SOURCE -D_XOPEN_SOURCE=500 
> -D_FILE_OFFSET_BITS=64 -funsigned-char -fno-strict-aliasing -Wall

A typical V=1 compile line looks like:

/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -I. -g -O2 -DNDEBUG 
-DVERSION=\"3.1.5\" -DLOCALEDIR=\"/usr/share/locale\" -DPACKAGE=\"xfsprogs\" 
-I../include -DENABLE_GETTEXT -D_GNU_SOURCE -D_XOPEN_SOURCE=500 
-D_FILE_OFFSET_BITS=64 -funsigned-char -fno-strict-aliasing -Wall    -c 
xfs_dir2_sf.c

for me.  The biggest thing is that you have another directory in your
include path.  How did you add that one? Did you add anything else
special to the ./configure or make command lines?

<Prev in Thread] Current Thread [Next in Thread>