[Top] [All Lists]

Re: [PATCH] xfstests: fix modulo-by-zero error in fsx

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix modulo-by-zero error in fsx
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 20 Jul 2011 18:04:15 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1311047353-23925-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1311047353-23925-1-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-07-19 at 13:49 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> The recent fsx fixes has a logic error in the offset trimming code.
> If a read is done when the file size is zero, then the logic error
> causes a offset % 0 opertaion to occur. This causes fsx to get a
> SIGFPE and die.
> This was not discovered during my testing because I was using a
> random seed that didn't trip this condition. Changing the seed to
> that which test 091 uses (the default of 1) causes such an operation
> to occur....
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

I realize you already committed this, but I'm finally
getting around to reviewing it.

I started composing this message, explaining how you
should have done something differently.  But at this
point it'll be more constructive to just send a patch
against what you have already committed.  So that will
be coming shortly...


<Prev in Thread] Current Thread [Next in Thread>