xfs
[Top] [All Lists]

Re: [PATCH 3/4] xfs: convert AIL cursors to use struct list_head

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/4] xfs: convert AIL cursors to use struct list_head
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 20 Jul 2011 10:19:35 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110719234324.GC9359@dastard>
References: <1310960419-9875-1-git-send-email-david@xxxxxxxxxxxxx> <1310960419-9875-4-git-send-email-david@xxxxxxxxxxxxx> <1311116636.1964.40.camel@doink> <20110719234324.GC9359@dastard>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-07-20 at 09:43 +1000, Dave Chinner wrote:
> On Tue, Jul 19, 2011 at 06:03:56PM -0500, Alex Elder wrote:
> > On Mon, 2011-07-18 at 13:40 +1000, Dave Chinne
. . .
> > > + * Get the next item in the traversal and advance the cursor.  If the 
> > > cursor
> > > + * was invalidated (indicated by a lip of 1), restart the traversal.
> >  * was invalidated (indicated by its item pointer's low bit being set),
> >  * restart the traversal.
> 
> I thought I fixed that. Hmmmm, I did fix a comment that said the
> same thing - just it wasn't the one you noticed. :/ I'll fix it up
> when I redo the splice code again.

Don't worry about it.  I'll change it (as I did here)
in my own copy and will use that (unless you give me
something newer before I'm ready to publish it).

You are welcome to update it later, of course.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>