xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfs: use a cursor for bulk AIL insertion

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs: use a cursor for bulk AIL insertion
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 20 Jul 2011 10:16:01 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110719233644.GB9359@dastard>
References: <1310960419-9875-1-git-send-email-david@xxxxxxxxxxxxx> <1310960419-9875-2-git-send-email-david@xxxxxxxxxxxxx> <1311116624.1964.38.camel@doink> <20110719233644.GB9359@dastard>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-07-20 at 09:36 +1000, Dave Chinner wrote:
> On Tue, Jul 19, 2011 at 06:03:44PM -0500, Alex Elder wrote:
> > On Mon, 2011-07-18 at 13:40 +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > > 
> > > Delayed logging can insert tens of thousands of log items into the
> > > AIL at the same LSN. When the committing of log commit records
> > > occur, we can get insertions occurring at a
. . .
> _after_ which the new
> >          * items should go.  If lip is null the AIL was empty, so
> >          * the new items go at the head of the AIL.
> >          */
> >         if (lip)
> >                 list_splice(list, &lip->li_ail);
> >         else
> >                 list_splice(list, &ailp->xa_ail);
> > }
> 
> 
> Looks cleaner, but I'll need to test it. Right now all my test
> resources are busy with non-mainline stuff, so it's going to be next
> week sometime before I can do this.

I'll actually try to test this today.   -Alex

<Prev in Thread] Current Thread [Next in Thread>