[Top] [All Lists]

Re: [PATCH] xfstests: fix modulo-by-zero error in fsx

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix modulo-by-zero error in fsx
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 19 Jul 2011 13:10:54 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1311047353-23925-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1311047353-23925-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jul 19, 2011 at 01:49:13PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> The recent fsx fixes has a logic error in the offset trimming code.
> If a read is done when the file size is zero, then the logic error
> causes a offset % 0 opertaion to occur. This causes fsx to get a
> SIGFPE and die.
> This was not discovered during my testing because I was using a
> random seed that didn't trip this condition. Changing the seed to
> that which test 091 uses (the default of 1) causes such an operation
> to occur....

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>