xfs
[Top] [All Lists]

Re: [PATCH 0/2 v8] XFS TESTS: ENOSPC Punch Hole Test

To: Allison Henderson <achender@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 0/2 v8] XFS TESTS: ENOSPC Punch Hole Test
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 18 Jul 2011 17:09:13 -0500
Cc: <linux-ext4@xxxxxxxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <1310946766-30217-1-git-send-email-achender@xxxxxxxxxxxxxxxxxx>
References: <1310946766-30217-1-git-send-email-achender@xxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Sun, 2011-07-17 at 16:52 -0700, Allison Henderson wrote:
> This patch set adds the ENOSPC test that was used for ext4 punch hole testing.
> This test will verify that a hole can be punched even when the disk is full.
> Reserved blocks should be used to complete the operation when there is not 
> blocks
> to further fragment the file.
> 
> Because punching a hole does not always require extra blocks, there needs to 
> be several iterations of punching holes, and then filling the file system to 
> 100% 
> usage before it is forced to grow the tree in order to handle the 
> fragmentation. 
> The growing of the tree is what would cause ENOSPC if not for the use of 
> reserved blocks.

I have reviewed both of your updated patches.  They
both look good to me.  I'll give it another day or
two for others to comment if they like, but unless
someone suggests changes I'll commit this for you.

Reviewed-by: Alex Elder <aelder@xxxxxxx>




> Allison Henderson (2):
>   XFS TESTS: ENOSPC Punch Hole: Move su routines in 123 to common.rc
>   XFS TESTS: Add ENOSPC Hole Punch Test
> 
>  123       |   24 ------------
>  256       |  120 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  256.out   |    1 +
>  common.rc |   81 +++++++++++++++++++++++++++++++++++++++++
>  group     |   12 ++++--
>  5 files changed, 210 insertions(+), 28 deletions(-)
>  create mode 100644 256
>  create mode 100644 256.out
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



<Prev in Thread] Current Thread [Next in Thread>