xfs
[Top] [All Lists]

Re: [PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 16 Jul 2011 13:03:52 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110716012147.6629.12496.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20110716012105.6629.24407.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110716012147.6629.12496.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> -                     memcpy((char *)dabuf->data + off, XFS_BUF_PTR(bp),
> +                     memcpy((char *)dabuf->data + off, bp->b_addr,
>                               XFS_BUF_COUNT(bp));
>               }
>       }
> @@ -2317,7 +2317,7 @@ xfs_da_buf_clean(xfs_dabuf_t *dabuf)
>               for (i = off = 0; i < dabuf->nbuf;
>                               i++, off += XFS_BUF_COUNT(bp)) {
>                       bp = dabuf->bps[i];
> -                     memcpy(XFS_BUF_PTR(bp), (char *)dabuf->data + off,
> +                     memcpy(bp->b_addr, (char *)dabuf->data + off,
>                               XFS_BUF_COUNT(bp));

While not strictly related it would be nice to kill tha (char *) casts
here while you're at it.

Otherwise the patch looks go,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>