xfs
[Top] [All Lists]

Re: [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 15 Jul 2011 22:00:08 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110716012122.6629.95933.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20110716012105.6629.24407.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110716012122.6629.95933.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jul 15, 2011 at 06:21:22PM -0700, Chandra Seetharaman wrote:
> Remove the definitions and usage of the macros XFS_BUF_ERROR,
> XFS_BUF_GETERROR and XFS_BUF_ISERROR.

Looks fine, although I'd prefer to just use bp->b_error directly instead
of xfs_buf_geterror when we know that bp is non-zero.

<Prev in Thread] Current Thread [Next in Thread>