[Top] [All Lists]

Re: [xfs-masters] [PATCH] xfs: failure mapping nfs fh to inode should re

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [xfs-masters] [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 15 Jul 2011 21:53:46 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20110716015014.GF21663@dastard>
References: <20110714205036.GA19457@xxxxxxxxxxxx> <20110714223126.GA28694@xxxxxxxxxxxxx> <20110716015014.GF21663@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Jul 16, 2011 at 11:50:14AM +1000, Dave Chinner wrote:
> Bulkstat also checks for ENOENT returns from xfs_iget() as the
> lookup it does is inherently racy. That is, if the inode is
> allocated when it is read from the IBT, but then has been unlinked
> before the actual xfs_iget() call, it expects to get back an ENOENT
> to tell it the inode has been unlinked and shouldn't be included in
> the bulkstat output. Otherwise, it returns the error to userspace.
> So converting the mode checks to return ESTALE definitely has the
> chance of breaking stuff that uses bulkstat (e.g. xfsdump) because
> it will return errors now where it previously just skipped the
> (unlinked) inode.

Sounds like we should simply go with the original version of the patch

<Prev in Thread] Current Thread [Next in Thread>