xfs
[Top] [All Lists]

Re: [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE

To: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 14 Jul 2011 18:31:26 -0400
Cc: Alex Elder <aelder@xxxxxxx>, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx
In-reply-to: <20110714205036.GA19457@xxxxxxxxxxxx>
References: <20110714205036.GA19457@xxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jul 14, 2011 at 04:50:36PM -0400, J. Bruce Fields wrote:
> From: J. Bruce Fields <bfields@xxxxxxxxxx>
> 
> On xfs exports, nfsd is incorrectly returning ENOENT instead of ESTALE
> on attempts to use a filehandle of a deleted file (spotted with pynfs
> test PUTFH3).  The ENOENT was coming from xfs_iget.

With that you mean the ip->i_d.di_mode checks?  Given that we should
only be bale to get these from NFS or the handle ioctls I suspect just
turning them into ESTALE should be fine.

<Prev in Thread] Current Thread [Next in Thread>