xfs
[Top] [All Lists]

Re: [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE

To: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 14 Jul 2011 17:25:50 -0500
Cc: <xfs-masters@xxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <linux-nfs@xxxxxxxxxxxxxxx>
In-reply-to: <20110714205036.GA19457@xxxxxxxxxxxx>
References: <20110714205036.GA19457@xxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Thu, 2011-07-14 at 16:50 -0400, J. Bruce Fields wrote:
> From: J. Bruce Fields <bfields@xxxxxxxxxx>
> 
> On xfs exports, nfsd is incorrectly returning ENOENT instead of ESTALE
> on attempts to use a filehandle of a deleted file (spotted with pynfs
> test PUTFH3).  The ENOENT was coming from xfs_iget.
> 
> (It's tempting to wonder whether we should just map all xfs_iget errors
> to ESTALE, but I don't believe so--xfs_iget can also return ENOMEM at
> least, which we wouldn't want mapped to ESTALE.)
> 
> While we're at it, the other return of ENOENT in xfs_nfs_get_inode()
> also looks wrong.
> 
> Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx>

Looks reasonable to me.

I'll give others a chance to weigh in, but otherwise I'll
get this in for Linux 3.1.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>