xfs
[Top] [All Lists]

Re: XFS Test Case:252 - Shows Wrong Output

To: Amit Sahrawat <amit.sahrawat83@xxxxxxxxx>
Subject: Re: XFS Test Case:252 - Shows Wrong Output
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 14 Jul 2011 13:40:15 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, Allison Henderson <achender@xxxxxxxxxxxxxxxxxx>
In-reply-to: <BANLkTi=yk3Z2KUnwtr6-H1BNhWG-XvJZPw@xxxxxxxxxxxxxx>
References: <BANLkTinBNa9ox+jDaorBoKdhoQQzTUA58A@xxxxxxxxxxxxxx> <BANLkTi=wHAxYuLE33AVsc2rp0eEm5GB40w@xxxxxxxxxxxxxx> <4E022818.7030406@xxxxxxxxxxxxxxxxxx> <BANLkTimuv183W0ef0aYCySWPnv9rLqNuww@xxxxxxxxxxxxxx> <20110623062030.GY32466@dastard> <BANLkTi=2rTU2R_hGGeMhLYzM6FKPOW0L8w@xxxxxxxxxxxxxx> <BANLkTinQig04y6Rc9MHGSfpbTSKZpmtHpQ@xxxxxxxxxxxxxx> <BANLkTin8oJi04CCrtGVsxFGiA9PLQEEtpA@xxxxxxxxxxxxxx> <BANLkTi=yk3Z2KUnwtr6-H1BNhWG-XvJZPw@xxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-06-24 at 12:45 +0530, Amit Sahrawat wrote:
> This has to be an issue with everyone who is using XFS version which is not
> supporting "fpunch" but still none has raised this. As per my view, the
> support checking function *_require_xfs_io_falloc_punch() *is not working
> correctly otherwise it should return from that point.
> 
> *Instead of:*
> echo $testio | grep -q "not found"
> If we are sure of a *"hole"* from that command, then we can grep for "hole"
> in $testio.
> 
> Please correct me if I am wrong.
> 
> Thanks & Regards,
> Amit Sahrawat

I think what you are saying is that in your environment,
_require_xfs_io_falloc_punch() is not properly deciding
whether the fpunch operation is supported.  And you are
suggesting a way to determine it properly, is that right?

Unfortunately it is difficult to know whether your
suggestion is a proper fix without knowing details of
your current system, as well as details about what
you are seeing that is incorrect.

We welcome suggested fixes from people.  Often that
takes the form of a patch that proposes a fix, but
if enough precise information is provided about the
problem we can sometimes develop a fix for you.

Can you supply either a patch with a proposed fix,
or else provide more information about exactly
what you are seeing?  Otherwise I don't think
we're going to be able to help.

Thanks.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>
  • Re: XFS Test Case:252 - Shows Wrong Output, Alex Elder <=