xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: don't hard code the shell binary

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: don't hard code the shell binary
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 14 Jul 2011 13:27:11 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <20110628074137.GA6123@xxxxxxxxxxxxx>
References: <1309245348-12638-1-git-send-email-david@xxxxxxxxxxxxx> <20110628074137.GA6123@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-06-28 at 03:41 -0400, Christoph Hellwig wrote:
> On Tue, Jun 28, 2011 at 05:15:48PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Recent changes to debian unstable user space have caused the
> > xfsprogs build to break as certain shell functionality is being
> > assumed by libtool and friends.  The configure scripts test and
> > select the correct shell, but the input files ignore this and hard
> > code the shell to use and hence now break.
> > 
> > Fix this by using the shell that the configure scripts decide is the
> > right one to use.
> 
> Looks good.  The same fix should also be applied to xfsdump, xfstests
> and dmapi.

Agree.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>


<Prev in Thread] Current Thread [Next in Thread>