xfs
[Top] [All Lists]

Re: [PATCH 05/11] xfs: add a proper transaction pointer to struct xfs_bu

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 05/11] xfs: add a proper transaction pointer to struct xfs_buf
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 12 Jul 2011 05:12:12 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1310423584.7019.57.camel@doink>
References: <20110710204916.856267100@xxxxxxxxxxxxxxxxxxxxxx> <20110710205017.667546845@xxxxxxxxxxxxxxxxxxxxxx> <1310423584.7019.57.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 11, 2011 at 05:33:04PM -0500, Alex Elder wrote:
> On Sun, 2011-07-10 at 16:49 -0400, Christoph Hellwig wrote:
> > Replace the typeless b_fspriv2 and the ugly macros around it with a properly
> > typed transaction pointer.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> So it looks like you do two things.
> - make it a real pointer (which it should be), when it's
>   used to keep track of the transaction a buffer is
>   associated with; and
> - eliminate the use of this field storing cast 1's and 2's
>   for verifying the way log buffers are used.
> 
> I don't see much value in the second one, and the first
> is the way it should be, so this looks good to me.

I should have mentioned that it also drops those pointless debug checks
in the log code.  I'll add it to the patch description.

<Prev in Thread] Current Thread [Next in Thread>